#PYTHON GENERATE RANDOM STRING OF LENGTH CODE#
#PYTHON GENERATE RANDOM STRING OF LENGTH FREE#

To get a list of letters, it would be somewhat shorter to write a string of letters and convert it to a list: caps = list('abcdefghijklmnopqrstuvwxyz')

(Note: I took this chance to rename list as lst so that we do not hide the list built-in function)įinally, this function could be replaced by: random.choice() but for the sake of learning, it is probably best to try to write (and use) your own implementation. Once it is done, we could wonder whether everything performed with index1list and the other numbered variables could be rewritten using our get_random_element.

#PYTHON GENERATE RANDOM STRING OF LENGTH CODE#

This highlights an issue that I'll let you fix (the code somehow runs properly because negative indices are accepted by Python but this is probably not what you intended nor what another programmer would expect by reading quickly the code). Once we have this function, we could take this change to check that idx-1 is in the valid range with assert 0 <= idx - 1 < leng. '''Documentation is to be written here.''' Among the various other benefits: we would be able to give it a meaningful name, add some documentation, test it, etc.įor instance, we could have: def get_random_element(lst): In our case, we could implement a function performing this logic. It could be a good idea to avoid having duplicated code which can be harder to read and maintain (see DRY). The 3 first parts of the loop look highly similar. You'll find various tools to check if your code is compliant to it and even tools to reformat your code automatically ( black). There is a Python style guide called PEP 8 which is definitely worth reading. Anyway, various things can be improved in the code without changing the behavior. The simpler and less surprising thing to do is generate a word from any of those characters: import randomĬhoices = ascii_lowercase + ascii_uppercase + digitsĭisclaimer: I'm note 100% sure that your code does what you think it does. The output word will have the choice of only one lower-case letter, one upper-case letter and one digit. Word = ''.join(random.choices(choices, k=6))īut your algorithm has some odd properties that, according to your comments, you did not intend. Rather than your manual, unrolled string appending, just use ''.join().Ī strictly equivalent implementation could be import randomįrom string import ascii_lowercase, ascii_uppercase, digitsįill_caps = random.choice(ascii_uppercase)įill_letter = random.choice(ascii_lowercase)Ĭhoices = (fill_letter, fill_caps, fill_number) it shadows an existing type called list, and 2. Replace your length / index / slice with a random.choices.ĭon't call a variable list, since 1.

#PYTHON GENERATE RANDOM STRING OF LENGTH FREE#

If this is duplicate, please feel free to tell me, because searching for things isn't one of my qualities.ĭon't use caps, numbers and letters those are all constants available from the string module.ĭon't assign j since it isn't used name the iteration variable _ instead.

Print(fill1list + fill2list + fill3list + fill4list + fill5list + fill6list) Indexletters=random.randint(0, lengthletters) Indexnumbers=random.randint(0, lengthnumbers) I decided to write this code just for fun, however I feel like the code can be made shorter. My code basically picks random letters and numbers from three lists and makes a random combination with them.

Python generate random string of length